Simplify PlayerFragment transaction

jellyfin · Sep 23, 2022 · 264fa60 · 264fa60
1 parent 19cf7c2
commit 264fa60
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/app/src/main/java/org/jellyfin/mobile/events/ActivityEventHandler.kt b/app/src/main/java/org/jellyfin/mobile/events/ActivityEventHandler.kt
@@ -5,7 +5,6 @@ import android.content.Intent
 import android.content.pm.ActivityInfo
 import android.net.Uri
 import android.os.Bundle
-import androidx.fragment.app.add
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.lifecycleScope
 import androidx.lifecycle.repeatOnLifecycle
@@ -59,13 +58,10 @@ class ActivityEventHandler(
                 }
             }
             is ActivityEvent.LaunchNativePlayer -> {
-                supportFragmentManager.beginTransaction().apply {
-                    val args = Bundle().apply {
-                        putParcelable(Constants.EXTRA_MEDIA_PLAY_OPTIONS, event.playOptions)
-                    }
-                    add<PlayerFragment>(R.id.fragment_container, args = args)
-                    addToBackStack(null)
-                }.commit()
+                val args = Bundle().apply {
+                    putParcelable(Constants.EXTRA_MEDIA_PLAY_OPTIONS, event.playOptions)
+                }
+                supportFragmentManager.addFragment<PlayerFragment>(args)
             }
             is ActivityEvent.OpenUrl -> {
                 try {

diff --git a/app/src/main/java/org/jellyfin/mobile/utils/extensions/FragmentManager.kt b/app/src/main/java/org/jellyfin/mobile/utils/extensions/FragmentManager.kt
@@ -9,9 +9,9 @@ import androidx.fragment.app.add
 import androidx.fragment.app.replace
 import org.jellyfin.mobile.R
 
-inline fun <reified T : Fragment> FragmentManager.addFragment() {
+inline fun <reified T : Fragment> FragmentManager.addFragment(args: Bundle? = null) {
     beginTransaction().apply {
-        add<T>(R.id.fragment_container)
+        add<T>(R.id.fragment_container, args = args)
         addToBackStack(null)
     }.commit()
 }