-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pgssub to ExoPlayer subtitle codecs #1043
Conversation
ExoPlayer supports decoding embedded pgssub subtitles, so they should be enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funnily enough I added this to the TV app 3 weeks ago :p
Nice 😄 |
So I guess I will place my warning here: I don't think ExoPlayer's implementation is all that solid yet. I've been meaning to capture a video of it happening compared to the web player, but if more than one track is supposed to show up on the screen at the same time, I had issues on the TV app with them not showing up correctly after we switched to native support from transcoding. In about 17 hours I should have free time to properly characterize the TV app, and if I still see issues I'll submit a ticket there. I can characterize the mobile app as well if we have a test image. |
Good point, support for multiple subtitles at the same time doesn't really exist yet with the current track selection code. Many movies have two sets of subtitles to provide subtitles for foreign languages spoken in the movie (also known as forced subtitles) in addition to the closed captions that transcribe all the conversations. I believe it would make sense to create a separate ticket for this issue. |
I think we might be referring to two different things (my fault, I worded it poorly). I think it's not so much that there are multiple tracks playing at the same time, rather it seems more like there are multiple, parallel captions of text on the screen, at different positions, but part of the same track...at least, in an MKV container it's only labeled as one track. Sadly that free time I thought I had is going to be delayed, but I will submit a separate ticket to the TV App repo and this one (assuming the same issue happens) once I have recordings of what it looks like across several clients. Otherwise, congrats on getting this and 2.5.0 out the door! |
ExoPlayer supports decoding embedded pgssub subtitles, so they should be enabled.
Tested locally and confirmed working.
I also removed the likely invalid
pgs
specification from the external player profile, since ffprobe lists pgs subtitles aspgssub
.