Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exoplayer #1158

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Update exoplayer #1158

merged 1 commit into from
Aug 16, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 16, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jellyfin.exoplayer:exoplayer-ffmpeg-extension 2.19.0+1 -> 2.19.1+1 age adoption passing confidence
com.google.android.exoplayer:extension-cronet 2.19.0 -> 2.19.1 age adoption passing confidence
com.google.android.exoplayer:extension-cast 2.19.0 -> 2.19.1 age adoption passing confidence
com.google.android.exoplayer:exoplayer-hls 2.19.0 -> 2.19.1 age adoption passing confidence
com.google.android.exoplayer:extension-mediasession 2.19.0 -> 2.19.1 age adoption passing confidence
com.google.android.exoplayer:exoplayer-ui 2.19.0 -> 2.19.1 age adoption passing confidence
com.google.android.exoplayer:exoplayer-core 2.19.0 -> 2.19.1 age adoption passing confidence

Release Notes

jellyfin/jellyfin-exoplayer-ffmpeg-extension (org.jellyfin.exoplayer:exoplayer-ffmpeg-extension)

v2.19.1+1: 2.19.1+1

Updates

Full Changelog: jellyfin/jellyfin-androidx-media@v2.19.0+1...v2.19.1+1

google/ExoPlayer (com.google.android.exoplayer:extension-cronet)

v2.19.1

This is the last planned release of the com.google.android.exoplayer2
artifacts. This project is now deprecated. All users should migrate to
androidx.media3 (which contains the same ExoPlayer code). See
the migration guide
for more details, including a script to help with the migration.

This release corresponds to the
AndroidX Media3 1.1.1 release.

  • Common Library:
    • Remove accidentally added multidex dependency from all modules
      (#​499).
  • ExoPlayer:
    • Fix issue in PlaybackStatsListener where spurious PlaybackStats are
      created after the playlist is cleared.
    • Add additional fields to Common Media Client Data (CMCD) logging:
      streaming format (sf), stream type (st), version (v), top birate (tb),
      object duration (d), measured throughput (mtp) and object type (ot)
      (#​8699).
  • Audio:
    • Fix a bug where Player.getState() never transitioned to STATE_ENDED
      when playing very short files
      (#​538).
  • Audio Offload:
    • Prepend Ogg ID Header and Comment Header Pages to bitstream for
      offloaded Opus playback in accordance with RFC 7845.
  • Video:
    • H.265/HEVC: Fix parsing SPS short and long term reference picture info.
  • Text:
    • CEA-608: Change cue truncation logic to only consider visible text.
      Previously indent and tab offset were included when limiting the cue
      length to 32 characters (which was technically correct by the spec)
      (#​11019).
  • IMA extension:
    • Bump IMA SDK version to 3.30.3.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update dependencies gradle labels Aug 16, 2023
@jellyfin-bot jellyfin-bot added this to the v2.6.0 milestone Aug 16, 2023
@renovate renovate bot force-pushed the renovate/exoplayer branch from e629f2f to 2ebf0a3 Compare August 16, 2023 21:04
@renovate renovate bot changed the title Update exoplayer to v2.19.1 Update exoplayer Aug 16, 2023
@Maxr1998 Maxr1998 enabled auto-merge (squash) August 16, 2023 21:05
@Maxr1998 Maxr1998 merged commit 4de69d8 into master Aug 16, 2023
@Maxr1998 Maxr1998 deleted the renovate/exoplayer branch August 16, 2023 21:10
@satmandu
Copy link

Testing this build I see this:

┬───
│ GC Root: Global variable in native code

├─ dalvik.system.PathClassLoader instance
│ Leaking: NO (MediaRouter↓ is not leaking and A ClassLoader is never
│ leaking)
│ ↓ ClassLoader.runtimeInternalObjects
├─ java.lang.Object[] array
│ Leaking: NO (MediaRouter↓ is not leaking)
│ ↓ Object[1227]
├─ androidx.mediarouter.media.MediaRouter class
│ Leaking: NO (a class is never leaking)
│ ↓ static MediaRouter.sGlobal
│ ~~~~~~~
├─ androidx.mediarouter.media.MediaRouter$GlobalMediaRouter instance
│ Leaking: UNKNOWN
│ Retaining 45.8 kB in 691 objects
│ mApplicationContext instance of org.jellyfin.mobile.JellyfinApplication
│ ↓ MediaRouter$GlobalMediaRouter.mCompatSession
│ ~~~~~~~~~~~~~~
├─ android.support.v4.media.session.MediaSessionCompat instance
│ Leaking: UNKNOWN
│ Retaining 37.8 kB in 578 objects
│ ↓ MediaSessionCompat.mImpl
│ ~~~~~
├─ android.support.v4.media.session.MediaSessionCompat$MediaSessionImplApi29
│ instance
│ Leaking: UNKNOWN
│ Retaining 2.3 kB in 29 objects
│ ↓ MediaSessionCompat$MediaSessionImplApi21.mSessionFwk
│ ~~~~~~~~~~~
├─ android.media.session.MediaSession instance
│ Leaking: UNKNOWN
│ Retaining 1.7 kB in 10 objects
│ mContext instance of org.jellyfin.mobile.player.audio.MediaService
│ ↓ MediaSession.mContext
│ ~~~~~~~~
╰→ org.jellyfin.mobile.player.audio.MediaService instance
Leaking: YES (ObjectWatcher was watching this because org.jellyfin.mobile.
player.audio.MediaService received Service#onDestroy() callback and
Service not held by ActivityThread)
Retaining 17.9 kB in 202 objects
key = 065f7914-1a32-4d10-88d6-6f2e81ee9ce5
watchDurationMillis = 532258
retainedDurationMillis = 527258
mApplication instance of org.jellyfin.mobile.JellyfinApplication
mBase instance of android.app.ContextImpl

METADATA

Build.VERSION.SDK_INT: 34
Build.MANUFACTURER: Google
LeakCanary version: 2.11
App process name: org.jellyfin.mobile.debug
Class count: 38996
Instance count: 263431
Primitive array count: 185550
Object array count: 39856
Thread count: 77
Heap total bytes: 36473411
Bitmap count: 2
Bitmap total bytes: 419073
Large bitmap count: 0
Large bitmap total bytes: 0
Db 1: open /data/user/0/org.jellyfin.mobile.debug/databases/jellyfin
Db 2: open /data/user/0/org.jellyfin.mobile.debug/databases/com.google.android.
datatransport.events
Stats: LruCache[maxSize=3000,hits=145313,misses=257701,hitRate=36%]
RandomAccess[bytes=12499395,reads=257701,travel=146071242159,range=43991881,size
=54342551]
Analysis duration: 966650 ms

@Maxr1998
Copy link
Member

Probably not a new issue, the cast implementation always had this context leak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update dependencies gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants