Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compile and target SDK to 34 #1160

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Update compile and target SDK to 34 #1160

merged 1 commit into from
Aug 19, 2023

Conversation

Maxr1998
Copy link
Member

No description provided.

@Maxr1998 Maxr1998 added the backport Pull request needs to be backported to current release branch label Aug 19, 2023
@Maxr1998 Maxr1998 added this to the v2.6.0 milestone Aug 19, 2023
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine but since it targets SDK 34 I'd like to wait for that to be stable and then merge.

We could also bump to SDK 33 now and 34 in a week or two.

@Maxr1998 Maxr1998 removed the backport Pull request needs to be backported to current release branch label Aug 19, 2023
@nielsvanvelzen nielsvanvelzen merged commit ca3513f into master Aug 19, 2023
@nielsvanvelzen nielsvanvelzen deleted the sdk-34 branch August 19, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants