Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto discovery #126

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Conversation

CarlosOlivo
Copy link
Contributor

Button only visible when at least one server is found

Closes #115 👀

@Maxr1998
Copy link
Member

Maxr1998 commented Sep 14, 2020

I love this, thank you so much! The only criticism I could spot in a quick review would probably be the standard AlertDialog with the newlines, but for now that's absolutely fine and in the future I may replace it with another UI anyways.
Gonna review it in detail later today, once I find the time.

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the correct approach in adding server discovery. In my opinion it should always start when the server selection screen is shown and display the results in the activity instead of using an dialog.

@@ -2,6 +2,7 @@
xmlns:tools="http://schemas.android.com/tools"
package="org.jellyfin.mobile">

<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this permission required for discovery to work? If so I'll add it to the apiclient for the next release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny how I knew it was required but forgot to actually add it to the manifest lol

@CarlosOlivo
Copy link
Contributor Author

I don't think this is the correct approach in adding server discovery. In my opinion it should always start when the server selection screen is shown and display the results in the activity instead of using an dialog.

Unfortunately for me the discovery of the cordova client never worked so, I don't know how it used to be the discovery UI, for me the UI is the login screen with a "Cancel" button that redirects to a no-op selectServer.html bundled in the web client (notice the height change in the title bar), but you are free to reimplement the UI to follow the original behavior / flow.

image
image

@Maxr1998 Maxr1998 added the enhancement New feature or request label Sep 19, 2020
@Maxr1998 Maxr1998 force-pushed the auto-discovery branch 2 times, most recently from f139eab to 85c693b Compare September 20, 2020 23:36
CarlosOlivo and others added 2 commits September 21, 2020 01:37
Immediately show server chooser after the first server has been discovered, replace withContext() with flowOn()
@Maxr1998 Maxr1998 merged commit 377a5a3 into jellyfin:master Sep 20, 2020
@CarlosOlivo CarlosOlivo deleted the auto-discovery branch September 21, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement auto discovery
3 participants