Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromecast: call success callback when result was successful #1296

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

dumpfheimer
Copy link
Contributor

Changes

Call the success callback when result was successful.

To be honest this is so obvious that I am not sure if I am not missing something. I am still having issues with casting but this should be a step in the right direction.

Issues

Possibly related: #1029

@jellyfin-bot jellyfin-bot added this to the v2.7.0 milestone Feb 14, 2024
@Maxr1998 Maxr1998 added bug Something isn't working cast Related to Google Cast labels Feb 14, 2024
@Maxr1998 Maxr1998 changed the title Chromecast bugfix Chromecast: call success callback when result was successful Feb 14, 2024
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have been in the code since before the rewrite, and I have no idea how I missed that. Thanks for spotting it!

@Maxr1998 Maxr1998 merged commit 12379d6 into jellyfin:master Feb 14, 2024
7 checks passed
@nielsvanvelzen nielsvanvelzen modified the milestones: v2.7.0, v2.6.1 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cast Related to Google Cast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants