-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing download network preference #1331
Allow changing download network preference #1331
Conversation
The issue I ran into is that |
True, that's definitely a shortcoming of the library. Not a huge problem though and we can change this later when the library gets updated to directly support ints, I believe.. the only thing that is a bit of a pain is that this new preference will store the setting twice (as int in Otherwise, this looks pretty good. Edit: the new 2.4.0-beta2 of the preferences libraries will support singleChoice with int keys, so we can also use that. I'll update to that version once the distribution is complete, and you can rebase on top of the latest master branch and make the required changes. Edit 2: done, you can now proceed. |
awesome thanks, was actually going to sit down today and look into updating the library so i'll get this wrapped up |
f055712
to
a850479
Compare
Rebased your PR onto the latest master branch and fixed the conflicts. Thanks for your contribution! |
Changes
Adds a section in the settings screen which gives users the option of changing their preferred download network. Previously, users were unable to allow or restrict mobile data downloads after making the initial choice. Additionally updates the message displayed when the initial dialog is displayed to inform users their choice can be updated.
Issues
Fixes #1326