Rework app / webapp communication #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Oct 5, 2020
| override fun onAdjustVolume(direction: Int) { | ||
| when (direction) { | ||
| AudioManager.ADJUST_RAISE -> { | ||
| webappFunctionChannel.triggerInputManagerAction(Constants.INPUT_MANAGER_COMMAND_VOL_UP) |
There was a problem hiding this comment.
They were already there in master xD
There was a problem hiding this comment.
Is it something we can fix or is it not possible without changing webui?
There was a problem hiding this comment.
It needs changes to the web UI, unfortunately. But then again, we'll probably have a native UI before we get those changes, lol.
app/src/main/java/org/jellyfin/mobile/webapp/RemoteVolumeProvider.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/webapp/RemoteVolumeProvider.kt
Outdated
Show resolved
Hide resolved
Maxr1998
force-pushed
the
rework-webapp-channel
branch
from
673efa9 to
2d19090
Compare
Put Kotlin channel inside wrapper class, use channel for communication from NativeInterface, RemotePlayerService and ExternalPlayer.
Maxr1998
force-pushed
the
rework-webapp-channel
branch
from
2d19090 to
b5019f2
Compare
nielsvanvelzen
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put Kotlin channel inside wrapper class, use channel for communication from NativeInterface, RemotePlayerService and ExternalPlayer.