Move video player into fragment #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
added
enhancement
nielsvanvelzen
requested changes
Oct 21, 2020
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
Maxr1998
force-pushed
the
player-fragment
branch
from
d75e3ad to
6611baf
Compare
nielsvanvelzen
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be pretty much complete and nearly everything works as before, the only thing I've noticed is that when returning from PiP into landscape mode, the player doesn't fill the whole screen until you tap the screen once. I don't know why that happens, and I don't want to spend much more time on it - it might actually be a framework bug.
Fixes #85.