Improve and rework MediaService & Android Auto integration #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
added
bug
|
Note: the code for search is untested, because Google Assistant is dumb and doesn't properly recognize queries directed at Jellyfin. |
|
You can use this app to test the integration - need to build it yourself though. |
|
Oh wait, I already have that installed! Thanks for reminding me 😅 EDIT: It works great! You unfortunately can't provide those "album" or "artist" extras within the testing app however. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nielsvanvelzen
requested changes
Nov 13, 2020
Moves library browser code into extra class and package, as it will only be used for Android Auto. The loader function was split into multiple subfunctions and cleaned up. The format of 'parentIds' was improved, unexpected behaviour with queue selection fixed. Shuffling was temporarily removed and will be handled differently in the future. Also introduces preliminaries for casting and Android 11 seamless transfer, this isn't fully enabled yet however - it seems there are still some changes necessary within the AndroidX libraries. Uses code from the android/uamp reference media player project: https://github.com/android/uamp
Maxr1998
force-pushed
the
media-service
branch
from
d25efc7 to
b1f2f6c
Compare
|
/azp run we should look into these build issues 😒 |
|
Command 'run
we' is not supported by Azure Pipelines.
See additional documentation. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nielsvanvelzen
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses code from the android/uamp reference media player project: https://github.com/android/uamp
Closes #226.