-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins modified to support es6 migration #240
Conversation
I think we should release one version of the Android app before 10.7 releases that supports both 10.6 and 10.7. A month after 10.7 we will remove the 10.6 support. To achieve this goal I think we need to:
This way we can keep supporting the 2 most used versions in the next few months. CC @Maxr1998 what do you think about this plan? And should we do it for 2.2 or for 2.3? |
That sounds good to me. I wouldn't be worried about duplicated files, as we'll later remove those anyways. |
If we do it in 2.3 we can confirm Google allows our changes for Android Auto this time. So I think that's a good approach. |
Yep, that's what I was thinking. Let's get that Android Auto out finally! |
Some quick testing for this PR:
|
I pushed some fixes that will hopefully load the plugins, need to wait on jellyfin/jellyfin-web#2139 and jellyfin/jellyfin-web#2137 to be merged so I can test though. |
af25b35
to
1ac54f1
Compare
1ac54f1
to
e7c986c
Compare
Tested with demo.jellyfin.org/unstable and demo.jellyfin.org/stable for web player, native player and external player and everything seems to work. The JavaScript in the 10.7 version is formatted with VSCode and I fixed some small issues like duplicate functions and switched from |
This PR introduces changes to exoplayer and externalplayer plugin, modifying them into classes and expose them in window.
Each plugin will have access to a set of dependencies in its constructor (invoked by jf-web).
also the list of plugins were modified so it can find these plugins in window.
This is still not tested, so i will try to test it somehow with the changes present in jellyfin/jellyfin-web#1994