Fix various playback crashes #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
added
bug
Maxr1998
force-pushed
the
crash-fixes
branch
3 times, most recently
from
ff4d84a to
97b693a
Compare
| @@ -45,7 +45,9 @@ export class ExternalPlayerPlugin { | |||
| this._paused = false; | |||
| this._currentSrc = options.url; | |||
| this._isIntro = options.item && options.item.ProviderIds && options.item.ProviderIds.hasOwnProperty("prerolls.video"); | |||
| this._externalPlayer.initPlayer(JSON.stringify(options.item.playOptions)); | |||
| let playOptions = options.item.playOptions; | |||
There was a problem hiding this comment.
Suggested change
| let playOptions = options.item.playOptions; | |
| const playOptions = options.item.playOptions; |
dkanada
reviewed
May 13, 2021
Comment on lines
+92
to
+94
| ).onSuccess { jellyfinMediaSource -> | ||
| playMediaSource(playOptions, jellyfinMediaSource) | ||
| }.onFailure { error -> |
There was a problem hiding this comment.
Is this an ExoPlayer thing or a Kotlin thing?
There was a problem hiding this comment.
It's the Result class
https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-result/
nielsvanvelzen
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371, #370, #368.