Extended webview checks #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
reviewed
May 14, 2021
Maxr1998
reviewed
May 14, 2021
Comment on lines
116
to
117
| appPreferences.ignoreWebViewChecks = false | ||
|
|
There was a problem hiding this comment.
Debugging left-overs?
Suggested change
| appPreferences.ignoreWebViewChecks = false |
|
|
|
Maybe the "ignore" should be at the bottom? |
|
|
Maxr1998
reviewed
May 15, 2021
| @@ -56,13 +59,20 @@ class MainActivity : AppCompatActivity() { | |||
| bindService(Intent(this, RemotePlayerService::class.java), serviceConnection, Service.BIND_AUTO_CREATE) | |||
|
|
|||
| // Check WebView support | |||
| if (!isWebViewSupported()) { | |||
| if (!appPreferences.ignoreWebViewChecks && !isWebViewSupported()) { | |||
There was a problem hiding this comment.
It already checks for ignore here, but there's no way to ignore from the "unsupported" dialog below.. seems like an oversight?
There was a problem hiding this comment.
I should definitely not work on the app when I'm half asleep 😅
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nielsvanvelzen
force-pushed
the
extended-webview-checks
branch
from
898a910 to
0b9c558
Compare
|
You forgot to handle the note, also necessary for devices without gapps (or alternative store like Aurora Store || F-Droid).
|
nielsvanvelzen
force-pushed
the
extended-webview-checks
branch
from
0b9c558 to
455f21d
Compare
|
Thanks @CarlosOlivo, added an additional check to see if the intent can be resolved 👍 |
Maxr1998
previously approved these changes
May 20, 2021
| } | ||
|
|
||
| // Only show button if the intent can be resolved | ||
| if(marketIntent.resolveActivity(context.packageManager) != null) { |
There was a problem hiding this comment.
Suggested change
| if(marketIntent.resolveActivity(context.packageManager) != null) { | |
| if (marketIntent.resolveActivity(context.packageManager) != null) { |
nielsvanvelzen
force-pushed
the
extended-webview-checks
branch
from
455f21d to
c482f83
Compare
Maxr1998
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
Adds an additional button to open the webview settings, it allows changing the used webview more easily. User needs to manually open the app again after changing it.
For the second alert (outdated webview) pressing on the background will cancel the dialog and never show it again. Adding an additional button was too much work because I'd need to make my own layout for it.
note: this one actually says "open settings" instead of "settings" but I was too lazy to re-capture