Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Webapp UI #445

Merged
merged 4 commits into from
Jun 20, 2021
Merged

Restructure Webapp UI #445

merged 4 commits into from
Jun 20, 2021

Conversation

Maxr1998
Copy link
Member

@Maxr1998 Maxr1998 commented Jun 19, 2021 •
edited
Loading

  • Move CoordinatorLayout to WebViewFragment, since it's only supposed to be used there anyways
  • Fade in WebView once the app has connected to the sever
  • Fix a potential NPE when setting the locale

The background icon as discussed in #436 is still missing, but this should be easy to add now. I will play with that tomorrow.

cc: @CarlosOlivo

@Maxr1998 Maxr1998 requested a review from nielsvanvelzen June 19, 2021 22:16
@Maxr1998 Maxr1998 added the enhancement New feature or request label Jun 19, 2021
@Maxr1998 @nielsvanvelzen
Update app/src/main/java/org/jellyfin/mobile/utils/UIExtensions.kt
71dd2e6 
Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
@nielsvanvelzen nielsvanvelzen merged commit a23ed55 into master Jun 20, 2021
@nielsvanvelzen nielsvanvelzen deleted the view-refactor branch June 20, 2021 08:31
@Maxr1998 Maxr1998 mentioned this pull request Aug 26, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maxr1998 @nielsvanvelzen