Improve session integration #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed PLAYER_TIME_UPDATE_RATE from 1 second to 10 seconds Stop active encoding if transcoding when playbacks ends
Maxr1998
force-pushed
the
fix-session-integration
branch
from
8c3dcca to
5e33634
Compare
Maxr1998
changed the title
|
I've rebased your PR and reverted the device ID change for now, since it has undesired side-effects for multiple users on one device, I have an idea how to fix this in a separate PR however. |
Maxr1998
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLAYER_TIME_UPDATE_RATEfrom 1 second to 10 secondsToo much spam before, to the level of slowing down the server (at least in my case), also is the default in jellyfin-web
Originally 2 sessions are created because jellyfin-web creates a singleton per device (many users - one device), while jellyfin-sdk-kotlin proposes one user per session (one user - one device)
In the case of jellyfin-web, as it is a Singleton, once NativeShell is injected the deviceId should not change or it causes unexpected behaviors
So
jellyfin-webandjellyfin-sdk-kotlinmust come to an agreement on what to do in these cases.Before
After