Split up web app and connection handling, use view binding for setup layout #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nielsvanvelzen I have decided to put the multi-server stuff into another PR, I have to spend some extra thoughts before implementing that. |
nielsvanvelzen
requested changes
Aug 24, 2020
app/src/main/java/org/jellyfin/mobile/webapp/ConnectionHelper.kt
Outdated
Show resolved
Hide resolved
| .mapNotNull(String::toIntOrNull) | ||
| when { | ||
| version.size != 3 -> false | ||
| version[0] == 10 && version[1] < 3 -> true // Valid old version |
There was a problem hiding this comment.
We might want to add the "supported version" as a constant somewhere so it can be changed more easily.
There was a problem hiding this comment.
I think the check is only there because of the "ProductName" variable that isn't available before 10.3..
There was a problem hiding this comment.
Hmm, I can imagine that some features in the nativeshell (and in the future, the apiclient) need a minimum version set too. Might even be a good thing to require 10.6.x at the release too.
Maxr1998
changed the title
app/src/main/java/org/jellyfin/mobile/webapp/ConnectionHelper.kt
Outdated
Show resolved
Hide resolved
Extract connection handling into extra class, don't reset server URL on errors, replace toasts with error text.
Maxr1998
force-pushed
the
extract-connection-handling
branch
from
13d9e3a to
d5b9d8a
Compare
nielsvanvelzen
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract connection handling into extra class, don't reset server URL on errors, replace toasts with error text.