Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specified video version in native player #637

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

mingyech
Copy link
Contributor

@mingyech mingyech commented Apr 4, 2022

User can specify a version of a video they want to play, but previously the native player does not play the specified version and plays the default version instead. Use the specified version from playOptions if available, similar to how it is handled in external player mode.

Fixes #585.

@nielsvanvelzen nielsvanvelzen requested a review from Maxr1998 April 4, 2022 08:40
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and worked fine in my tests. Thank you!

@Maxr1998 Maxr1998 enabled auto-merge (squash) April 6, 2022 11:39
@Maxr1998 Maxr1998 merged commit d20333c into jellyfin:master Apr 6, 2022
@mingyech mingyech deleted the video-version-fix branch April 6, 2022 16:11
@nielsvanvelzen nielsvanvelzen added this to the v2.5.0 milestone Aug 15, 2022
@Maxr1998 Maxr1998 added the bug Something isn't working label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated player: Duration / Runtime seems to be taken from metadata instead of the actual data
3 participants