-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notify method to strip escaped HTML characters. #775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating this! Your fix looks good, but I found you could replace your helper function with a compat function from AndroidX.
The title is also used in some other places like the media session metadata. I'm not sure if we should fix the HTML in those places too. |
Are those shown somewhere where they wouldn't be decoded by the system? |
Media session metadata can be read by any app and I don't think they expect HTML in the strings. |
Right. Should we still merge this already and have a different PR for the other issue? |
Yeah that's fine |
So, after doing some investigation I found that it was actually the
notify
method in theRemotePlayerService
class. Not sure why some properties show escaped HTML characters instead of their standard equivalents, and it may be worth looking into why the characters are returned that way from the server. For now, however, this should suffice and allow special characters to be displayed without issue. See the before and after picture below for proof of bug fix, as well.EDIT: This addresses issue #731, btw