Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notify method to strip escaped HTML characters. #775

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

colonelpopcorn
Copy link
Contributor

@colonelpopcorn colonelpopcorn commented Aug 31, 2022

So, after doing some investigation I found that it was actually the notify method in the RemotePlayerService class. Not sure why some properties show escaped HTML characters instead of their standard equivalents, and it may be worth looking into why the characters are returned that way from the server. For now, however, this should suffice and allow special characters to be displayed without issue. See the before and after picture below for proof of bug fix, as well.
jelly-fin-before-after

EDIT: This addresses issue #731, btw

Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this! Your fix looks good, but I found you could replace your helper function with a compat function from AndroidX.

app/src/main/java/org/jellyfin/mobile/utils/HtmlUtils.kt Outdated Show resolved Hide resolved
@Maxr1998 Maxr1998 linked an issue Aug 31, 2022 that may be closed by this pull request
3 tasks
@nielsvanvelzen
Copy link
Member

The title is also used in some other places like the media session metadata. I'm not sure if we should fix the HTML in those places too.

@Maxr1998
Copy link
Member

Maxr1998 commented Sep 9, 2022

Are those shown somewhere where they wouldn't be decoded by the system?

@nielsvanvelzen
Copy link
Member

Media session metadata can be read by any app and I don't think they expect HTML in the strings.

@Maxr1998
Copy link
Member

Maxr1998 commented Sep 9, 2022

Right. Should we still merge this already and have a different PR for the other issue?

@nielsvanvelzen
Copy link
Member

Yeah that's fine

@Maxr1998 Maxr1998 merged commit 23794a8 into jellyfin:master Sep 9, 2022
@nielsvanvelzen nielsvanvelzen added this to the v2.5.0 milestone Sep 23, 2022
@Maxr1998 Maxr1998 added the bug Something isn't working label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Characters in lock screen media controls are URL encoded
3 participants