Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise compileSdk to 33 #805

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Raise compileSdk to 33 #805

merged 1 commit into from
Sep 22, 2022

Conversation

Maxr1998
Copy link
Member

I think this should be enough for the moment to merge #780.

@Maxr1998 Maxr1998 added this to the v2.5.0 milestone Sep 21, 2022
nielsvanvelzen
nielsvanvelzen reviewed Sep 22, 2022
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do media notifications (now playing) still work in Android 13 with this PR?

@Maxr1998
Copy link
Member Author

Yes, the compileSdk doesn't affect the behavior of the app, it only allows to use new APIs without imposing any restrictions. The targetSdk would need to be raised to enable new behaviors.

@nielsvanvelzen nielsvanvelzen merged commit 6a8858f into master Sep 22, 2022
@nielsvanvelzen nielsvanvelzen deleted the sdk-33 branch September 22, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Maxr1998 @nielsvanvelzen