Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automatically change orientation for landscape video by default #809

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

eglia
Copy link
Contributor

@eglia eglia commented Sep 23, 2022

This change prevents the screen orientation from automatically changing on playback start in ExoPlayer.

The player now keeps the currently active screen orientation. When the device is rotated (with auto-rotate active), the player rotates accordingly. The player is also rotated when pressing the fullscreen button.

Only works in ExoPlayer, the web player still shows the old behaviour. I'm not sure where the corresponding code is for the web player.

Probably fixes #141

@Maxr1998
Copy link
Member

The way it currently works is modelled after other video players like mpv. Jellyfin doesn't show any additional data (description, comments) like YouTube, and thus the focus can be on the video which should be shown as large as possible.

We can, of course, make this behavior configurable, since I noticed other video players (VLC, …) behave differently and this seems more like a personal preference.

@eglia
Copy link
Contributor Author

eglia commented Sep 24, 2022

Feel free to make it configurable, but I'm afraid this exceeds my capabilities in this project.

I find the current behaviour annoying and no other players I use (VLC, YouTube) behaves that way.
I also don't see the need for it, if I want to watch in landscape I can simply turn my phone and the video turns with it.

@Maxr1998
Copy link
Member

Feel free to make it configurable, but I'm afraid this exceeds my capabilities in this project.

Sure, I can do that.

I find the current behaviour annoying and no other players I use (VLC, YouTube) behaves that way.

There doesn't seem to be a common behavior really, as I said, mpv does just that.

I also don't see the need for it, if I want to watch in landscape I can simply turn my phone and the video turns with it.

Only if auto-rotate is enabled, or by manually pressing the fullscreen button (which is another step). I can see how that can be annoying as well.

Making it configurable really seems to be the best option.

@Maxr1998 Maxr1998 removed their request for review September 24, 2022 13:26
@Maxr1998 Maxr1998 enabled auto-merge (squash) November 26, 2022 00:32
@Maxr1998 Maxr1998 merged commit b8db53f into jellyfin:master Nov 26, 2022
@nielsvanvelzen nielsvanvelzen added this to the v2.5.0 milestone Mar 18, 2023
@Maxr1998 Maxr1998 added the enhancement New feature or request label May 13, 2023
@Maxr1998 Maxr1998 changed the title don't automatically change orientation for landscape video Don't automatically change orientation for landscape video by default May 13, 2023
@Maxr1998 Maxr1998 mentioned this pull request May 28, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable portrait mode
3 participants