Implement downloadFiles in NativeShell #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd good to mention that even without this PR everything will keep working. jellyfin-web automatically falls back to using multiple downloadFile calls when downloadFiles is not implemented. |
Maxr1998
requested changes
Oct 16, 2022
app/src/main/java/org/jellyfin/mobile/bridge/NativeInterface.kt
Outdated
Show resolved
Hide resolved
nielsvanvelzen
force-pushed
the
nativeshell-download-multiple-files
branch
from
25a8031 to
757b774
Compare
Maxr1998
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jellyfin 10.9 will add a new function to the NativeShell: downloadFiles. This is the same as downloadFile but can request multiple files at once.
This PR adds a basic implementation for it, internally it splits the request. In the future we can use a queue or something to download the files more efficiently.
Changes
Issues
jellyfin-web pull request: jellyfin/jellyfin-web#4016