Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-apply milestones #866

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Auto-apply milestones #866

merged 2 commits into from
Oct 31, 2022

Conversation

Maxr1998
Copy link
Member

Tested in Maxr1998/jellyfin-android#1.

@Maxr1998 Maxr1998 added enhancement New feature or request ci CI related pull requests or issues github-actions Pull requests that update or change GitHub Actions labels Oct 26, 2022
@Maxr1998 Maxr1998 added this to the v2.5.0 milestone Oct 26, 2022
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this script will fail if we make a milestone for the next minor release (0.15.0) and then decide to create another patch release (0.14.5) because the latter will be the newest.

.github/workflows/repo-milestone.yaml Outdated Show resolved Hide resolved
@Maxr1998
Copy link
Member Author

It'll use the oldest open/active milestone (0.15.0) which, in my opinion, is the right choice. If there are PRs directly going to the patch release, you can still manually override the milestone.

.github/workflows/repo-milestone.yaml Outdated Show resolved Hide resolved
.github/workflows/repo-milestone.yaml Outdated Show resolved Hide resolved
.github/workflows/repo-milestone.yaml Outdated Show resolved Hide resolved
@nielsvanvelzen nielsvanvelzen merged commit 31ff5e5 into master Oct 31, 2022
@nielsvanvelzen nielsvanvelzen deleted the auto-milestones branch October 31, 2022 19:45
@Maxr1998 Maxr1998 removed the enhancement New feature or request label May 13, 2023
@Maxr1998 Maxr1998 removed this from the v2.5.0 milestone May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related pull requests or issues github-actions Pull requests that update or change GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants