Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential crash when user reopens the app quickly #911

Merged

Conversation

susonthapa
Copy link
Contributor

Changes
I actually ran into this issue when I reopened the app quickly. The app will crash when it tries to release the MediaRouter callbacks.
SCR-20221127-r8v

@jellyfin-bot jellyfin-bot added this to the v2.5.0 milestone Nov 27, 2022
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a few more fixes for issues that could cause similar crashes. Eventually, I'll have to rewrite this code from scratch, Java's null safety is really terrible…

@Maxr1998 Maxr1998 enabled auto-merge (squash) December 4, 2022 18:23
@Maxr1998 Maxr1998 merged commit ffdf1ec into jellyfin:master Dec 4, 2022
@Maxr1998 Maxr1998 added the bug Something isn't working label May 13, 2023
@Maxr1998 Maxr1998 changed the title fixed potential crash when user reopens the app quickly Fix potential crash when user reopens the app quickly May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants