Fix and rewrite audio and subtitle track selection when transcoding #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
added
bug
Maxr1998
force-pushed
the
fix-transcoding-selection
branch
2 times, most recently
from
00f3b89 to
9f2ac56
Compare
nielsvanvelzen
requested changes
Dec 24, 2022
| // We need to remove the dashes so that the server can find the correct media source. | ||
| // And if we didn't pass the mediaSourceId, our stream indices would silently get ignored. | ||
| // https://github.com/jellyfin/jellyfin/blob/9a35fd673203cfaf0098138b2768750f4818b3ab/Jellyfin.Api/Helpers/MediaInfoHelper.cs#L196-L201 | ||
| mediaSourceId = itemId.toString().replace("-", ""), |
There was a problem hiding this comment.
This conversion feels hacky, do we not have a reference to the mediasource so we can use the id from that?
There was a problem hiding this comment.
It is hacky but sadly not. The id shouldn't be a string anyways but the api model would require changes for this.
There was a problem hiding this comment.
@crobibero can you help us out here, would it be possible to 1) change the parameter type to a UUID, or 2) allow a UUID with dashes to be auto-converted serverside?
There was a problem hiding this comment.
Which parameter do you want changed? MediaSourceInfo?
There was a problem hiding this comment.
The mediaSourceId, but I don't know whether it has to support other than UUIDs too.
Maxr1998
force-pushed
the
fix-transcoding-selection
branch
from
9f2ac56 to
69cecbc
Compare
nielsvanvelzen
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.