avcodec/libopusenc: Allow 5.1(side) channel inputs #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the 5.1(side) channel layouts will get rejected by libopus encoder because vorbis layout expects 5.1(back) channel layout. However, the side channels and back channels have same position in the layout mapping. Relax the layout checking to allow such side to back mappings.
Shadowghost
approved these changes
May 2, 2024
nyanmisaka
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously the 5.1(side) channel layouts will get rejected by libopus encoder because vorbis layout expects 5.1(back) channel layout. However, the side channels and back channels have same position in the layout mapping.
Relax the layout checking to allow such side to back mappings.
Issues
Fixes #248
Prepare for jellyfin/jellyfin-web#5434