Remove __shortcuts__ and clean up related code.

[oddstr13]

Going via __shortcuts__ and __getitem__ makes it harder to figure out where functions are used.

jellyfin-kodi/resources/lib/jellyfin/core/connection_manager.py

Lines 62 to 97 in c12918f

	def __shortcuts__(self, key):
	if key == "clear":
	return self.clear_data
	elif key == "servers":
	return self.get_available_servers()
	elif key in ("reconnect", "refresh"):
	return self.connect
	elif key == "login":
	return self.login
	elif key == "server":
	return self.get_server_info(self.server_id)
	elif key == "server-id":
	return self.server_id
	elif key == "server-version":
	return self.server_version
	elif key == "user-id":
	return self.jellyfin_user_id()
	elif key == "public-users":
	return self.get_public_users()
	elif key == "token":
	return self.jellyfin_token()
	elif key == "manual-server":
	return self.connect_to_address
	elif key == "connect-to-server":
	return self.connect_to_server
	elif key == "server-address":
	server = self.get_server_info(self.server_id)
	return get_server_address(server, server['LastConnectionMode'])
	elif key == "revoke-token":
	return self.revoke_token()
	elif key == "server-mode":
	server = self.get_server_info(self.server_id)
	return server['LastConnectionMode']
	return

[TrueTechy]

Adding this list here to keep track of work still needing done

Shortcuts

• resources/lib/jellyfin/core/configuration.py
• resources/lib/jellyfin/core/connection_manager.py
• resources/lib/jellyfin/core/http.py
• resources/lib/jellyfin/core/ws_client.py

Getitem

• resources/lib/jellyfin/init.py

• Has a decorator function on set/get functions, might need to reimplement these elsewhere

• resources/lib/jellyfin/client.py

• resources/lib/jellyfin/core/configuration.py:

• resources/lib/jellyfin/core/connection_manager.py:

• resources/lib/objects/movies.py

• resources/lib/objects/music.py

• resources/lib/objects/musicvideos.py

• resources/lib/objects/tvshows.py

[TrueTechy]

All of the cleanup has been committed and merged for this issue, it can now be closed.