-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix music syncing for Kodi 18 retaining Kodi 17 compatibility #32
Conversation
Also removes the message in kodi 18 to scan media. tested in kodi 17 and 18.
This pull request also fixes #31 which is the strArtists issue in the music72 db. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs just fine in Kodi 17 (I rebased on master).
If it also runs fine in Kodi 18, I'd say go for merge as soon as the indentation error is fixed.
Runs fine as is, but I would prefer not introducing formatting errors whenever possible.
I'm also assuming that 72
is the appropriate version for this distinction, as I'm not familiar with the versioning scheme, nor the exact version the music db change was introduced.
Kodi MusicDB goes from Kodi 17 - Music60 to Kodi 18 -Music72: |
referred here from another (i guess the same?) issue. installed the supplied updated plugin and initially it didn't work. But after renaming my kodi config folder to start fresh, this started scanning without issue (so far). |
Confirmed. Current master works (https://github.com/jellyfin/jellyfin-kodi/archive/master.zip). But i had to reset my kodi too. Is a reset really necessary? |
I just finalized my move from emby to jellyfin. This time, instead of resetting completely, i just created a new profile and made it my default. This way at least everything I needed was already downloaded and installed. |
Looks nice, any idea on when it will be released on the plugin repository ? |
I want to improve debug loging first, to make new issues easier to track down |
Fixes music syncing for kodi 18 while still usable by kodi 17.
Also removes the message in kodi 18 to scan media.
tested in kodi 17 and 18.
Fixes #12
Fixes #31