Make sure __base__ is the first place we look for packages. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddstr13
added
bug
|
Ugh, my local master is tracking origin not upstream, I'll try to get the rebase done tomorrow |
joshuaboniface
approved these changes
Aug 18, 2019
oddstr13
force-pushed
the
pr-importorder-1
branch
from
317379b to
5265b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resources/lib/entrypoint/service.pyis importingsetup, which just so happens to be a system package on this computer, which exits on import.This was leading to a hard to track down (debug prints all the way from entry point) bug with no error message - it just didn't work.
These changes make sure the local addon files are searched first for modules to import, instead of last.