Fix music multidisc indexing #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodi uses internally a right-shift operation to codify in a single integer disc number and track number. This is taken into account in this addon but, incorrectly, it is done for discnumber > 1 only, while Kodi uses it for tracks in all discs. Fix this by directly codifying the track and disc number for all discs. This patch is based on investigation by user @neightwulf in github.
|
Kudos, SonarCloud Quality Gate passed!
|
oddstr13
approved these changes
Aug 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 21.05% 21.05%
=======================================
Files 63 63
Lines 8544 8543 -1
Branches 1573 1572 -1
=======================================
Hits 1799 1799
+ Misses 6729 6728 -1
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kodi uses internally a right-shift operation to codify in a single integer disc number and track number. This is taken into account in this addon but, incorrectly, it is done for discnumber > 1 only, while Kodi uses it for tracks in all discs.
Fix this by directly codifying the track and disc number for all discs.
This patch is based on investigation by user @neightwulf in github.
Fixes #732