Fix Specials being added during season refresh when IncludeMissingSpe…

…cials is disabled (#152)
jellyfin · Jun 4, 2024 · f42a468 · f42a468
1 parent 9c7a524
commit f42a468
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Jellyfin.Plugin.Tvdb/Configuration/config.html b/Jellyfin.Plugin.Tvdb/Configuration/config.html
@@ -76,7 +76,7 @@ <h2 class="sectionTitle">TheTVDB Settings:</h2>
                     document.getElementById('cacheDurationInDays').value = config.CacheDurationInDays;
                     document.getElementById('metadataUpdateInHours').value = config.MetadataUpdateInHours;
                     document.getElementById('fallbackLanguages').value = config.FallbackLanguages;
-                    document.getElementById('includeMissingSpecials').checked = config.IncludeMissingSpecials || true;
+                    document.getElementById('includeMissingSpecials').checked = config.IncludeMissingSpecials;
                     Dashboard.hideLoadingMsg();
                 });
             },

diff --git a/Jellyfin.Plugin.Tvdb/Providers/TvdbMissingEpisodeProvider.cs b/Jellyfin.Plugin.Tvdb/Providers/TvdbMissingEpisodeProvider.cs
@@ -192,6 +192,13 @@ private async Task HandleSeason(Season season, IReadOnlyList<EpisodeBaseRecord>?
             var allEpisodes = allEpisodesRemote ?? await GetAllEpisodes(tvdbId, series.DisplayOrder, season.GetPreferredMetadataLanguage())
                 .ConfigureAwait(false);
 
+            // Skip if called from HandleSeries since it will be filtered there, allEpisodesRemote will not be null when called from HandleSeries
+            // Remove specials if IncludeMissingSpecials is false
+            if (allEpisodesRemote is null && !IncludeMissingSpecials)
+            {
+                allEpisodes = allEpisodes.Where(e => e.SeasonNumber != 0).ToList();
+            }
+
             var seasonEpisodes = allEpisodes.Where(e => e.SeasonNumber == season.IndexNumber).ToList();
             var existingEpisodes = season.GetEpisodes().OfType<Episode>().ToHashSet();