Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play local trailers #761

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Play local trailers #761

merged 1 commit into from
Sep 3, 2022

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Aug 28, 2022

Changes
Adds support for playing local trailers to the movie detail page.

Demo
See it in action: https://twitter.com/1hitsong/status/1563694392329781248

Fixes: #350

@neilsb
Copy link
Member

neilsb commented Aug 31, 2022

Seems to work well. Only difference from web is that it will play all the trailers once after the other (if there are multiple), whereas this will only play the 1st one in the list returned by the API with no ability to see any of the others.

Not saying that is not a valid thing to do - just querying if it was intentional?

@1hitsong
Copy link
Member Author

1hitsong commented Aug 31, 2022

It was intentional this time.

We don't have an API param for StartItemId like we do with PlayNextEpisode. So we would need to keep track of which one just played and which is next, etc. I figured instead of adding all that code immediately, we'd take the first baby step in supporting local trailers.

Once the video manager / playlist work is completed, then we can add all the trailers as a playlist and this won't be an issue.

When/if this is released, we should note this difference from the WebUI.

@jimdogx
Copy link
Contributor

jimdogx commented Sep 1, 2022

FYI, this Fixes: #350

@neilsb neilsb merged commit 524e3f0 into jellyfin:unstable Sep 3, 2022
@1hitsong 1hitsong deleted the support-local-trailers branch September 3, 2022 11:51
@cewert cewert mentioned this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for local trailers
3 participants