-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Genres, Parental Ratings, and Years as Movie Filters #928
Conversation
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
@1hitsong if you resolve the conflicts I'll re-test this with the latest unstable branch 👍 |
Something weird is happening with the view, but I don't know if it's related to this PR. If I filter by a Genre (which works great), when I start to scroll down through the movies, as soon as it needs to load the next set (spinner is shown), it takes you back to the top of the movie list. |
I was able to recreate this. I'll look int it. |
@jimdogx Should be fixed now. |
When I set a genre for the first time inside a movie folder it does not save or load the genre I selected. However on the second try it does save the genre and filter by the selected genre. Win.20230205.21.40.11.Pro.mp4 |
I am experiencing this issue as well. |
@candry7731 I'm trying as many different ways as I can, but I can't recreate this issue. I'll keep at it.
I can't say I've thought about it all that much. This is the existing functionality though. I can guarantee someone would get mad if we changed how it worked now.
I'm open to ideas, but I figure this works fine for s first release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding what @sevenrats said, the persisting doesn't bother me however I am wondering if there should be some indication that things are filtered. For example, when filtering TV shows it states at the top what it's filtered by.
Eventually, I'd like to get to the point that you can apply multiple filters from various categories. Perhaps we can simply indicate the results are filtered and the user can open the filter menu to see what all is applied? Or some kind of mini-info block that tells what the filters are? I'll give this some thought and have a followup PR. |
Changes
Adds Genres, Parental Ratings, and Years as filters for movies.
Currently you can only select 1 filter at a time, but you can selected multiple values for that filter. A followup PR can add the ability to select multiple filters.
Demo: https://social.linux.pizza/@tgpo/109587441382119771