Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Genres, Parental Ratings, and Years as Movie Filters #928

Merged
merged 6 commits into from
Feb 25, 2023
Merged

Add Genres, Parental Ratings, and Years as Movie Filters #928

merged 6 commits into from
Feb 25, 2023

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Dec 27, 2022

Changes
Adds Genres, Parental Ratings, and Years as filters for movies.

Currently you can only select 1 filter at a time, but you can selected multiple values for that filter. A followup PR can add the ability to select multiple filters.

Demo: https://social.linux.pizza/@tgpo/109587441382119771

image

@1hitsong 1hitsong marked this pull request as ready for review December 27, 2022 19:54
@github-actions
Copy link

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@github-actions github-actions bot added the stale This issue/PR has gone stale. label Jan 18, 2023
@1hitsong 1hitsong removed the stale This issue/PR has gone stale. label Jan 20, 2023
@jimdogx
Copy link
Contributor

jimdogx commented Jan 25, 2023

@1hitsong if you resolve the conflicts I'll re-test this with the latest unstable branch 👍

@jimdogx
Copy link
Contributor

jimdogx commented Jan 25, 2023

Something weird is happening with the view, but I don't know if it's related to this PR.

If I filter by a Genre (which works great), when I start to scroll down through the movies, as soon as it needs to load the next set (spinner is shown), it takes you back to the top of the movie list.

@1hitsong
Copy link
Member Author

I was able to recreate this. I'll look int it.

@1hitsong
Copy link
Member Author

@jimdogx Should be fixed now.

@candry7731
Copy link
Contributor

When I set a genre for the first time inside a movie folder it does not save or load the genre I selected. However on the second try it does save the genre and filter by the selected genre.

Win.20230205.21.40.11.Pro.mp4

@sevenrats
Copy link
Member

sevenrats commented Feb 8, 2023

When I set a genre for the first time inside a movie folder it does not save or load the genre I selected. However on the second try it does save the genre and filter by the selected genre.

Win.20230205.21.40.11.Pro.mp4

I am experiencing this issue as well.
It also seems strange that the filters persist through restarting the app. It makes sense for the views to persist imho, but not the filters.
It would be great if there was a better solution for the year picker.

@1hitsong
Copy link
Member Author

1hitsong commented Feb 8, 2023

@candry7731 I'm trying as many different ways as I can, but I can't recreate this issue. I'll keep at it.

@sevenrats

It also seems strange that the filters persist through restarting the app. It makes sense for the views to persist imho, but not the filters.

I can't say I've thought about it all that much. This is the existing functionality though. I can guarantee someone would get mad if we changed how it worked now.

It would be great if there was a better solution for the year picker.

I'm open to ideas, but I figure this works fine for s first release.

Copy link
Contributor

@jimdogx jimdogx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding what @sevenrats said, the persisting doesn't bother me however I am wondering if there should be some indication that things are filtered. For example, when filtering TV shows it states at the top what it's filtered by.

@1hitsong
Copy link
Member Author

Regarding what @sevenrats said, the persisting doesn't bother me however I am wondering if there should be some indication that things are filtered. For example, when filtering TV shows it states at the top what it's filtered by.

Eventually, I'd like to get to the point that you can apply multiple filters from various categories. Perhaps we can simply indicate the results are filtered and the user can open the filter menu to see what all is applied?

Or some kind of mini-info block that tells what the filters are?

I'll give this some thought and have a followup PR.

@github-actions github-actions bot added the merge-conflict This PR has a merge conflict label Feb 25, 2023
@github-actions github-actions bot removed the merge-conflict This PR has a merge conflict label Feb 25, 2023
@1hitsong 1hitsong merged commit 2eff140 into jellyfin:unstable Feb 25, 2023
@1hitsong 1hitsong deleted the AddMovieFilters branch February 25, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants