Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting in CI #220

Closed
nielsvanvelzen opened this issue Apr 11, 2021 · 4 comments
Closed

Add linting in CI #220

nielsvanvelzen opened this issue Apr 11, 2021 · 4 comments
Assignees
@nielsvanvelzen
Labels
ci enhancement New feature or request

Comments

@nielsvanvelzen
Copy link
Member

The current Gradle setup includes the Android linter (automatically added for Android projects) and Detekt (manually added) for linting. Right now both are unused in the GitHub actions.

I'd like to automatically lint the codebase on pull requests and report any new issues using annotations or in a comment. My previous attempt (#163) didn't work out like I wanted so I'll need to rethink how to approach this issue.
@nielsvanvelzen nielsvanvelzen added enhancement New feature or request ci labels Apr 11, 2021
@nielsvanvelzen nielsvanvelzen self-assigned this Apr 11, 2021
@nielsvanvelzen nielsvanvelzen mentioned this issue Apr 11, 2021
Closed
9 tasks
@nielsvanvelzen
Copy link
Member Author

It might be possible to convert the output of the linter to a SARIF file and upload it using the upload-sarif action.

Relevant GitHub documentation: https://docs.github.com/en/code-security/secure-coding/uploading-a-sarif-file-to-github

@nielsvanvelzen nielsvanvelzen mentioned this issue Apr 17, 2021
Merged
@nielsvanvelzen
Copy link
Member Author

Added Detekt linting in #229

Future linters:

@nielsvanvelzen
Copy link
Member Author

Android linting added in #237. Still waiting for Ktlint support.

@nielsvanvelzen
Copy link
Member Author

I've decided to keep it at Android+Detekt, might add more linters in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nielsvanvelzen nielsvanvelzen

Labels
ci enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nielsvanvelzen