-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SARIF format #1102
Comments
So it is basically adding another reporter that will produce report in |
That's correct. |
Because SARIF is officially supported by Github code action, we could show the violations inline (https://github.com/chao2zhang/detekt/pull/9/files) |
Then it makes sense to add such reporter. Feel free to contribute 👍 |
@chao2zhang do you plan to further improve SARIF format support or it is fine as it is? |
We can close this issue since we have basic support. Further improvements can be done in separate issues:
|
@chao2zhang have you tested ktlint reports in GitHub? It looks like the calculation of URI paths is incorrect, I was not able to make it work with out ktlint plugins... Any examples, where it works? |
@akuleshov7 send PR? |
Рома, we are supporting it in maven and gradle plugins for our diktat ruleset. Here is some small test: see: The idea is the following: the user adds a special flag As soon as I will finish with diktat - I will move the logic to your plugins. |
Github has the capabilitiy to integrate third-party static analysis tools. The official documentation can be found here which requires static analysis tools to produce [SARIF] format.
This issue is already picked up in
I would like to seek your opinion on supporting SARIF format as first-class for ktlint. (We already have json format https://github.com/pinterest/ktlint/tree/master/ktlint-reporter-json).
If approved, I would be happy to contribute as well.
The text was updated successfully, but these errors were encountered: