fix: Use VItemGroup to display settings list again #1855
Conversation
v-list-item-group is not available anymore in Vuetify 3. We use v-item-group instead. We use templates with v-slot:prepend and v-slot:append to place the icons correctly before or behind the actual settings name and description.
There was a problem hiding this comment.
One small thing and it's ready to go.
This should have been reported as a warning by your code editor. If it didn't, tell us so we can try to help you configure VSCode appropiately :) (Codespaces are a quick and good way to start up quickly as well).
The vite branch is full of linter and type errors right now, but it's not that we don't care about them and adding code with warnings is good, it's just that it's a work in progress :).
| <v-avatar> | ||
| <v-icon :icon="linkItem.icon" /> | ||
| </v-avatar> | ||
| <template v-slot:prepend> |
There was a problem hiding this comment.
| <template v-slot:prepend> | |
| <template #prepend> |
This is the first occurence in the PR, but you used this syntax everywhere else. Revisit those as well please.
There was a problem hiding this comment.
Done.
My VSCode did not warn me about it.
I am using the development container and installed all suggested extensions.
Something else I should have configured?
There was a problem hiding this comment.
@Janbong Did you wait for npm install to complete?
Cloudflare Pages deployment
|
|
Kudos, SonarCloud Quality Gate passed!
|
v-list-item-group seems to be not available anymore in Vuetify 3. I can't find any information on it. We use v-item-group (not v-list-group which was causing the settings not to show up) instead.
We use templates with v-slot:prepend and v-slot:append to place the icons correctly before or behind the actual settings name and description.