perf(vue3): improve index loading times by only blocking navigation at login #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferferga
force-pushed
the
improve-loading
branch
2 times, most recently
from
a1476eb
to
6418944
Compare
ferferga
force-pushed
the
improve-loading
branch
from
6418944
to
cc6a865
Compare
frontend/src/components/Layout/Carousel/CarouselProgressBar.vue
Outdated
Show resolved
Hide resolved
frontend/src/components/Layout/Carousel/CarouselProgressBar.vue
Outdated
Show resolved
Hide resolved
ferferga
force-pushed
the
improve-loading
branch
from
cc6a865
to
96bdfe6
Compare
frontend/src/components/Layout/Carousel/CarouselProgressBar.vue
Outdated
Show resolved
Hide resolved
…ion API With the improvements on loading, items of the carousel would change after the component is instantiated. However, there were some issues preventing the components from being reactive. By migrating to Composition API, those reactivity issues are fixed.
ferferga
force-pushed
the
improve-loading
branch
from
96bdfe6
to
d86be5b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
ThibaultNocchi
approved these changes
Feb 22, 2023
frontend/src/components/Layout/Carousel/CarouselProgressBar.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to reactivity bugs (which need to be solved for the index to properly load, as the content might change after the Carousel component is mounted), the remaining Carousel components are migrated to Composition API.