Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update Dockerfile to adapt it to the new config.json #1901

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

ferferga
Copy link
Member

  • Fix some markup validation errors in index.html
  • Fix config.json fetching
  • Fix incorrect variable name for external config

* Fix some markup validation errors in index.html
* Fix config.json fetching
* Fix incorrect variable name for external config
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 2cae6ba
Status ✅ Deployed!
Preview URL https://40ccfe2e.jf-vue.pages.dev
Type 🔀 Preview

View build logs
View bot logs

Copy link
Member

@ThibaultNocchi ThibaultNocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThibaultNocchi ThibaultNocchi merged commit 2c0681c into vite Mar 18, 2023
@ThibaultNocchi ThibaultNocchi deleted the docker-config branch March 18, 2023 15:54
@ferferga ferferga added this to the Vue 3 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Pull requests that edit Dockerfiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants