Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reloading after client changes #1939

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix: reloading after client changes #1939

merged 2 commits into from
Apr 10, 2023

Conversation

ferferga
Copy link
Member

This should work out of the box for clients that have been running already, but the service worker will be permanent to them. all data associated with the site must be cleared for it to be completeley gone.

This prevented building on MacOS since the categories were incorrect

Possible categories here: tauri-apps/tauri@6218238
frontend/index.html Outdated Show resolved Hide resolved
We can always reintroduce Vite PWA once we iron out the
rest of the things and our app is more ready to work offline
(by properly using stores, for example)

The status of workbox support is unclear, once it's clear we can
think about supporting it again: vite-pwa/vite-plugin-pwa#452
@sonarcloud
Copy link

sonarcloud bot commented Apr 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit e2c26cd
Status ✅ Deployed!
Preview URL https://83c1f817.jf-vue.pages.dev
Type 🔀 Preview

View build logs
View bot logs

Copy link
Member

@ThibaultNocchi ThibaultNocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThibaultNocchi ThibaultNocchi merged commit 22e7127 into master Apr 10, 2023
@ThibaultNocchi ThibaultNocchi deleted the fix-cache branch April 10, 2023 21:28
@ferferga ferferga mentioned this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants