Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(subtitles): settings & custom element for external subtitles #2360

Merged
merged 31 commits into from
Sep 12, 2024
Merged

feat(subtitles): settings & custom element for external subtitles #2360

merged 31 commits into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. feat(subtitles): settings & custom element for external subtitles

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6f66f06 View commit details
    Browse the repository at this point in the history

  2. fix: change subtitle stroke css properties to work with chromium brow… 

    …sers
    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9ddb61d View commit details
    Browse the repository at this point in the history

  3. fix(settings): refactor subtitle page to await loading and general le… 

    …gibility fixes
    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    56f3212 View commit details
    Browse the repository at this point in the history

  4. refactor(subtitles): use computed value for current subtitle variable

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3a6a4e4 View commit details
    Browse the repository at this point in the history

  5. fix(locale): general fixes regarding subtitles

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b8ad765 View commit details
    Browse the repository at this point in the history

  6. refactor(subtitles): make SSA file parsing more reliable and add mult… 

    …i-line dialogue together
    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2b3e52e View commit details
    Browse the repository at this point in the history

  7. refactor: reuse SubtitleTrack element in subtitle settings page

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b48f2d8 View commit details
    Browse the repository at this point in the history

  8. refactor: update replaceTags method to replace entire tags

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6d2cda6 View commit details
    Browse the repository at this point in the history

  9. fix: general tag formatting changes for rendering as html

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c723dc1 View commit details
    Browse the repository at this point in the history

  10. refactor: use uno css for subtitle track styles

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a048aeb View commit details
    Browse the repository at this point in the history

  11. refactor: check if useFullscreen is supported to apply custom subtitl… 

    …e track
    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6b1cbc0 View commit details
    Browse the repository at this point in the history

  12. refactor: add logic for basic sass subtitles

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2c44ebc View commit details
    Browse the repository at this point in the history

  13. refactor: link fontsize & position sliders directly to client settings

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9ded2d8 View commit details
    Browse the repository at this point in the history

  14. feat(FontSelector): refactor font selector logic and move to component

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    114617f View commit details
    Browse the repository at this point in the history

  15. feat(font-settings): query font from document css

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c875ff2 View commit details
    Browse the repository at this point in the history

  16. style: automatic eslint fix

    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    eba345c View commit details
    Browse the repository at this point in the history

  17. fix: handle cases where ssa sub dialogue include newline character

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bea50ad View commit details
    Browse the repository at this point in the history

  18. refactor(player-element): cleanup & standardize applying subtitles

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e7193fe View commit details
    Browse the repository at this point in the history

  19. refactor(playback-manager): reduce shared code

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    99b4827 View commit details
    Browse the repository at this point in the history

  20. refactor: fix sonarcloud issues

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fd0398d View commit details
    Browse the repository at this point in the history

  21. feat: implement useFont compostable

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    22f025c View commit details
    Browse the repository at this point in the history

  22. refactor: extract all subtitle setting functionality to new store

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    20e5480 View commit details
    Browse the repository at this point in the history

  23. refactor: simplify subtitle store 

    Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    49c313c View commit details
    Browse the repository at this point in the history

  24. refactor&fix: font 

    * Reduce unnecessary verbosity of the stores
* Extract the current typography of the application as a CSS variable
* Make font selector truly generic and also able to change the typography of the whole app

There are now 3 internal values:
- auto: for following app's font
- system: for following system's font
- default: default app's font

This way subtitles can be truly configurable independently from the app.

App typography follows the same schema, but without 'auto' since it's not applicable there.

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    89a5dbc View commit details
    Browse the repository at this point in the history

  25. feat: don't apply subtitle settings if customization is disabled 

    Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c98ae0e View commit details
    Browse the repository at this point in the history

  26. refactor: extract all logic to webworker 

    Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fb4c56a View commit details
    Browse the repository at this point in the history

  27. perf: optimize subtitle finding 

    Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bdacaff View commit details
    Browse the repository at this point in the history

  28. refactor(store): skip syncing font family 

    Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1e8d0bc View commit details
    Browse the repository at this point in the history

  29. refactor: address review comments 

    Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
    @ferferga
    ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ec3d5e2 View commit details
    Browse the repository at this point in the history

  30. refactor: fix displaying subtitle tracks

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    74ab7d3 View commit details
    Browse the repository at this point in the history

  31. refactor: improvements and fixes for jassub rendering

    @seanmcbroom @ferferga
    seanmcbroom authored and ferferga committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    aa797ae View commit details
    Browse the repository at this point in the history