fix(findSubtitle) add start index to final index after slice #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-line dialogue together
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
* Reduce unnecessary verbosity of the stores * Extract the current typography of the application as a CSS variable * Make font selector truly generic and also able to change the typography of the whole app There are now 3 internal values: - auto: for following app's font - system: for following system's font - default: default app's font This way subtitles can be truly configurable independently from the app. App typography follows the same schema, but without 'auto' since it's not applicable there. Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
seanmcbroom
changed the title
Cloudflare Pages deployment
|
|
okay, my branch is clearly messed up. i'm going to refork this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.