Remove Vueper Slides & replace with Swiper #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyhippari
force-pushed
the
remove-vueper
branch
from
190f394
to
8c2a84f
Compare
camc314
reviewed
Dec 24, 2020
heyhippari
force-pushed
the
remove-vueper
branch
from
8c2a84f
to
0949dce
Compare
ferferga
reviewed
Dec 26, 2020
ferferga
reviewed
Dec 26, 2020
camc314
reviewed
Dec 27, 2020
heyhippari
force-pushed
the
remove-vueper
branch
from
0949dce
to
e224af9
Compare
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=========================================
- Coverage 0.56% 0.56% -0.01%
=========================================
Files 87 88 +1
Lines 2287 2311 +24
Branches 354 355 +1
=========================================
Hits 13 13
- Misses 2273 2297 +24
Partials 1 1
Continue to review full report at Codecov.
|
ferferga
requested changes
Dec 28, 2020
ferferga
approved these changes
Jan 8, 2021
heyhippari
force-pushed
the
remove-vueper
branch
from
e224af9
to
2973626
Compare
heyhippari
force-pushed
the
remove-vueper
branch
from
2973626
to
fa23495
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all instances of Vueper Slides in the code, and replaces all the uses with Swiper. The reasoning is that Swiper is a better library and is officially supported on Vue 3 already.
This also removes some code duplication by creating a
<swiper-section>component, which is able to take all the options of the various old usages of Vueper and replaces it everywhere. It incorporates the loading skeleton, allows you to override the section title and supports multiple sections on one page (through generating a UUID for each instance, which is then used in the root class of the component in order to differentiate it from other instances of Swiper on the page).This change also leads to fixing a major issue with the old sliders, which prevented usage on mobile. These new sections use per-page navigation on non-mobile devices, while mobile devices use a more mobile-appropriate "free mode" to allow swiping through items easily.