-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create account settings page #717
Conversation
const title = | ||
this.$t('settingsSections.user.account.name') + | ||
' (' + | ||
this.$auth.user.Name + | ||
')'; | ||
this.setPageTitle({ title }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be translated together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in /settings/admin/ when it should be accessibly by all users? shouldnt it be in /settings?
@jellyfin rebase |
eaf00ca
to
0b5eada
Compare
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 25.26% 24.85% -0.42%
==========================================
Files 139 140 +1
Lines 3843 3907 +64
Branches 718 718
==========================================
Hits 971 971
- Misses 2843 2907 +64
Partials 29 29
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media. |
Cherrypicked from #633
This might not work standalone or look right as it was made around that PR. That PR must be merged first.