Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create account settings page #717

Closed
wants to merge 1 commit into from
Closed

Conversation

ferferga
Copy link
Member

Cherrypicked from #633

This might not work standalone or look right as it was made around that PR. That PR must be merged first.

@ferferga ferferga added the blocked Something depends on another issue or Pull Request label Feb 11, 2021
Comment on lines +207 to +212
const title =
this.$t('settingsSections.user.account.name') +
' (' +
this.$auth.user.Name +
')';
this.setPageTitle({ title });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be translated together

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in /settings/admin/ when it should be accessibly by all users? shouldnt it be in /settings?

@ferferga
Copy link
Member Author

@jellyfin rebase

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #717 (0b5eada) into master (817d2a5) will decrease coverage by 0.41%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   25.26%   24.85%   -0.42%     
==========================================
  Files         139      140       +1     
  Lines        3843     3907      +64     
  Branches      718      718              
==========================================
  Hits          971      971              
- Misses       2843     2907      +64     
  Partials       29       29              
Impacted Files Coverage Δ
pages/settings/admin/account.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817d2a5...0b5eada. Read the comment docs.

@github-actions github-actions bot added the vue Pull requests that edit or add Vue files label Mar 11, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stale
Copy link

stale bot commented Jun 2, 2021

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale This issue or PR hasn't been updated in at least 60 days label Jun 2, 2021
@stale stale bot closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something depends on another issue or Pull Request stale This issue or PR hasn't been updated in at least 60 days vue Pull requests that edit or add Vue files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants