Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Clicking on primary cover art at movie detail page does not play the movie anymore #5609

Closed
1 task done
mr-simba opened this issue May 26, 2024 · 3 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@mr-simba
Copy link

Please describe your bug

Before updating to jellyfin 10.9 it was possible to play the movie by clicking on the primary cover art at the movie detail page. This is not working any more.

First I thought, there was a general problem with jellyfin. After some time, I found out, that you can still play a video by clicking on the play icon, but not on the primary cover art (which is standard in the UI of most media servers) ....

Reproduction Steps

  1. Go to the detail page of a movie
  2. Click on the primary cover art left to the title
  3. Noting happens

Jellyfin Version

10.9.0

if other:

No response

Environment

Docker Image of Jellyfin 10.9.2 on QNAP TS-253Be. 
Clients: Web and Android

Jellyfin logs

-

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mr-simba mr-simba added the bug Something isn't working label May 26, 2024
@jellyfin-bot

This comment has been minimized.

@crobibero crobibero transferred this issue from jellyfin/jellyfin May 26, 2024
@thornbill
Copy link
Member

This was an intentional change as having multiple primary actions on the page is considered a bad practice. It was also broken for any item that was not playable (people for example).

#4881

@thornbill thornbill closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
@AlexBocken
Copy link

Although I definitely understand the reasoning for this approach I always found it quite useful myself. Here's a hacky way to get this behaviour back in your instance @mr-simba

Simply add the following to your index.html (/usr/share/webapps/jellyfin/web/index.html in my case)
at the end before </body>:

<script>
// Function to add click listener if not already added
function addClickListener() {
    const detailImageContainer = document.querySelector('.detailImageContainer');

    // Check if the listener has already been added using a custom attribute
    if (detailImageContainer && !detailImageContainer.dataset.clickListenerAdded) {
        detailImageContainer.addEventListener('click', function() {
            const playButton = document.querySelector(".btnPlay[title='Play'], .btnPlay[title='Resume']");
            if (playButton) {
                playButton.click();
            }
        });

        // Mark that the click listener has been added
        detailImageContainer.dataset.clickListenerAdded = 'true';
    }
}

// Run the function every second
setInterval(addClickListener, 1000);
</script>

Extremely janky (especially the setInterval part, but an eventlistener wouldn't do it for me...) but works smoothly across clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants