Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove click action from item details primary image #4881

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Adds a new function to build an image only card without any additional functionality
  • Changes the item details primary image to use this function
  • Removes click handling on the primary image

Issues
This was called out by the new ui/ux team as being a major issue on the item details page.
Fixes #4234
Supersedes #4272

@thornbill thornbill added enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX labels Oct 15, 2023
@thornbill thornbill requested a review from a team as a code owner October 15, 2023 06:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 0e2e8e4
Status ✅ Deployed!
Preview URL https://4927bce5.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web client tries to play nonexistent media when clicking on actor photo
3 participants