Deleting a user should show name #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made the changes to the required UI files, and the English strings files. I've left the other language files alone as I would not be able to accurately translate |
|
|
Chris-Codes-It
changed the title
dmitrylyzo
reviewed
Nov 6, 2023
dmitrylyzo
added
enhancement
Chris-Codes-It
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Gauvino
approved these changes
Jan 25, 2024
|
ptalmeida
reviewed
Feb 3, 2024
|
|
||
| if (!userId) { | ||
| console.error('Unexpected null user id'); | ||
| return; | ||
| } | ||
|
|
||
| if (!username) { |
There was a problem hiding this comment.
Do we need to return if no username exists? if we only need the userId I think this check isn't necessary and could prevent the deletion of some buggy user with a missing username.
This comment was marked as outdated.
This comment was marked as outdated.
thornbill
approved these changes
Mar 17, 2024
thornbill
force-pushed
the
feature/deleting_a_user_should_show_name
branch
from
87ef7cb to
e62bad4
Compare
dmitrylyzo
requested changes
Mar 17, 2024
thornbill
force-pushed
the
feature/deleting_a_user_should_show_name
branch
from
c7548d3 to
150964a
Compare
dmitrylyzo
approved these changes
Mar 17, 2024
|
Cloudflare Pages deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Amended Delete User dialog title to include username of user to be deleted
Issues
https://features.jellyfin.org/posts/2392/deleting-a-user-should-show-name