Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filters by "NoSubtitles" #5884

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

PabloTorres1975
Copy link

As my first contribution I added a new filter option to view only items without subtitles
(the inverse of HasSubtitles, currently you can only filter items with subtitles present.)

Changes to filterfeatures, filtertemplates, filterdialogs etc.

The string "NoSubtitiles" should be added to the translation files ( in spanish = "Sin Subtítulos" )

@PabloTorres1975 PabloTorres1975 requested a review from a team as a code owner August 6, 2024 20:08
@PabloTorres1975
Copy link
Author

Example image image

@thornbill
Copy link
Member

What is the use case for this?

@thornbill thornbill added the question Further information is requested label Aug 23, 2024
@PabloTorres1975
Copy link
Author

What is the use case for this?

There was no direct way to filter items in the library with missing subtitles (only with present subtitles) in case the plugin or bazarr does not find any so anyone can go and manually search them or translate/create them ...

Copy link

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 37d80f8bd05d07ad262ce1b8080c7610dca12faf
Status ✅ Deployed!
Preview URL https://aab750de.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill
Copy link
Member

This seems like more of an administrative feature and not something that is generally useful when playing media. iirc the Reports plugin can already find media without subtitles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants