feat(clients/vue): create deployment documentation #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferferga
commented
Sep 10, 2024
felix920506
reviewed
Sep 10, 2024
ferferga
force-pushed
the
vue-deployment
branch
from
1457f32
to
3c7f53a
Compare
felix920506
reviewed
Sep 11, 2024
|
@felix920506 This is already specified in the environment variables section (see the complete reference link) |
felix920506
approved these changes
Sep 11, 2024
|
@Gauvino Thank you very much for your feedback! |
oddstr13
reviewed
Sep 11, 2024
ferferga
force-pushed
the
vue-deployment
branch
from
d99815b
to
d28bdfc
Compare
oddstr13
approved these changes
Sep 12, 2024
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
The hashtag at the beginning makes possible that Docusaurus still renders the page's title, rendering the rest of the headers at h2< size, which is needed to keep a better distinction between the different sections Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com> Co-authored-by: Gauvino <68083474+Gauvino@users.noreply.github.com> Co-authored-by: Odd Stråbø <oddstr13@openshell.no>
ferferga
force-pushed
the
vue-deployment
branch
from
d28bdfc
to
49ea0e3
Compare
Cloudflare Pages deployment
|
ferferga
added a commit
to jellyfin/jellyfin-vue
that referenced
this pull request
Sep 12, 2024
The new deployment documentation has been pushed to the main Jellyfin documentation: jellyfin/jellyfin.org#1110 The wiki has also been updated to reflect those changes: https://github.com/jellyfin/jellyfin-vue/wiki/Deployment/81af939a4773c985cf5b64a33436200bee0f12f1 The last required piece was the repository's README Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought of a necessary security disclaimer while redacting the docs, and they were also applicable to the testing instructions added in #1104