Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies disappear in the router #188

Closed
litlfred opened this issue Sep 11, 2014 · 2 comments · Fixed by #193
Closed

Cookies disappear in the router #188

litlfred opened this issue Sep 11, 2014 · 2 comments · Fixed by #193

Comments

@litlfred
Copy link
Contributor

http://media.giphy.com/media/whNK1SAMSQjwQ/giphy.gif
@litlfred
Copy link
Contributor Author

koa use the cookie module which doesn't let you get the names pillarjs/cookies#52

litlfred added a commit that referenced this issue Sep 12, 2014
@litlfred
passes cookies on. fixes #188
48d53b2
@litlfred
Copy link
Contributor Author

These allows the cookies to pass through. However this is modifying the ctx.cookies, and should probably only happen with the primary route (if I understand what the primary route is). However to do so probably requires some discussion.

@litlfred litlfred mentioned this issue Sep 12, 2014
Merged
MattyJ007 pushed a commit that referenced this issue Jan 11, 2019
Merge pull request #188 from jembi/visualizer-responsive
f15699b 
Visualizer responsive - closes #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass cookies through primary route + pass route in sendRequest jembi/openhim-core-js
1 participant
@litlfred