Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests that include an accept gzip header break #196

Closed
hnnesv opened this issue Sep 18, 2014 · 5 comments
Closed

Requests that include an accept gzip header break #196

hnnesv opened this issue Sep 18, 2014 · 5 comments
Assignees
Milestone

Comments

@hnnesv
Copy link
Contributor

hnnesv commented Sep 18, 2014

If a request includes the header Accept-Encoding: gzip the following error occurs:

info: Routing http(s) request
zlib.js:222
    callback(null, buf);
    ^
TypeError: undefined is not a function
    at Gunzip.onEnd (zlib.js:222:5)
    at Gunzip.EventEmitter.emit (events.js:129:20)
    at _stream_readable.js:898:16
    at process._tickDomainCallback (node.js:372:11)
@hnnesv hnnesv added the bug label Sep 18, 2014
@rcrichton rcrichton modified the milestone: v1.0.x Oct 13, 2014
@BMartinos
Copy link
Collaborator

@rcrichton @devcritter I don't think the gzip issue hasn't been resolved in a module update. When testing on my local instance i was able to send a basic curl command, adding (-H "Accept-Encoding: gzip,deflate") which went through fine. The transaction gets created and i can see the Accept-Encoding: gzip in the transaction header.

However when i tested this on the preprod server the transactions is stuck in processing. I used the curl command with the certificate details which works fine without the Accept-Encoding header, but when i add it in it stays in processing. (Prob due to the error described above).
curl -v --insecure --key test/_/key.pem --cert test/_/cert.pem https://openhim-preprod.jembi.org:5000/sample/api -H "JsonStub-User-Key: *******************" -H "JsonStub-Project-Key: *************" -H "Accept-Encoding: gzip,deflate"

I am not sure if this is a issue only on pre-prod or a certificates issue?

@rcrichton
Copy link
Member

Maybe the module on preproduction need to be updated?

@rcrichton
Copy link
Member

@BMartinos what do you think we should do here? Was their anything useful in the server logs that point to an exception occurring? Is it the same exception that Hannes noticed?

@hnnesv
Copy link
Contributor Author

hnnesv commented Nov 4, 2014

To recreate the issue, try setting up a channel that routes to a server that supports gzip responses, e.g. try setting up a passthrough to something like apache. The issue occurred when I was routing requests to such a service and they were responding with compressed data.

@rcrichton
Copy link
Member

Closed in #261

MattyJ007 pushed a commit that referenced this issue Jan 11, 2019
Root user password reset
closes #193  
closes #196
closes #197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants