prevent port conflict between prometheus and datalake

[drizzentic]

Summary by CodeRabbit

• Chores
  • Updated port configuration for the MinIO service, changing the published port from 9090 to 9393.
  • Modified the command syntax for the MinIO service to ensure correct server instance creation.

[coderabbitai]

Walkthrough

The changes involve updates to the docker-compose configurations for the MinIO service in two files: datalake/docker-compose.dev.yml and datalake/docker-compose.yml. In the development configuration, the published port for the minio-01 service has been changed from 9090 to 9393. In the main docker-compose.yml file, the command for the minio-01 service has been modified to use a double dot (..) instead of a single dot (.) for the NUM_MINIO_SERVERS variable, affecting how the shell interprets the server instance range.

Changes

File	Change Summary
datalake/docker-compose.dev.yml	Updated published port for minio-01: 9090 → 9393.
datalake/docker-compose.yml	Modified command for minio-01: changed from . to .. in NUM_MINIO_SERVERS variable syntax.

Poem

In the land of code where rabbits play,
Ports and commands dance and sway.
MinIO hops from nine to nine-three,
With double dots, it sets servers free!
A joyful tune in the dev's bright light,
Hopping along, everything feels just right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)

datalake/docker-compose.yml (2)

Line range hint 12-12: Update default MINIO_SERVER_URL to use the new port

For consistency with the port change:

-      MINIO_SERVER_URL: ${MINIO_SERVER_URL:-http://localhost:9090}
+      MINIO_SERVER_URL: ${MINIO_SERVER_URL:-http://localhost:9393}

---

Line range hint 14-14: Update healthcheck URL to use the new port

For consistency with the port change:

-      test: [ "CMD", "curl", "-f", "http://localhost:9090/minio/health/live" ]
+      test: [ "CMD", "curl", "-f", "http://localhost:${MINIO_API_PORT:-9393}/minio/health/live" ]

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f11f0cf and 8490e5b.

📒 Files selected for processing (2)

• datalake/docker-compose.dev.yml (1 hunks)
• datalake/docker-compose.yml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• datalake/docker-compose.dev.yml

🔇 Additional comments (1)

datalake/docker-compose.yml (1)

Line range hint 7-14: Verify port changes across the entire stack

Please ensure that:

1. All services depending on MinIO are updated to use the new port
2. The port change is consistently applied in both development and production environments
3. No other services in the stack are using port 9393

[ItsMurumba]

LGTM!

[brett-onions]

LGTM